Skip to content

test(core): fix AI tools test flake #69201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dgp1130 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

test(core): fix AI tools test flake #69201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/core/test/debug/ai/registration_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,17 @@
import {signalGraphTool} from '../../../src/debug/ai/signal_graph';
import {registerAiTools} from '../../../src/debug/ai';
import {DevtoolsToolDiscoveryEvent} from '../../../src/debug/ai/tool_definitions';
import {destroyPlatform} from '../../../src/core';

describe('registration', () => {
beforeEach(() => {
// Destroy any pre-existing platform created by other tests which wasn't properly destroyed.
// Creating a platform calls `registerAiTools` in its production code path and unregisters when the platform is destroyed.
// If a platform leaks between tests, then there is an extra active AI tools event listener which can break these tests.
// The easiest solution is to just destroy any leaked platforms to make sure the environment is stable before we run.
destroyPlatform();
});

describe('registerAiTools', () => {
it('should register the tools', () => {
const unregister = registerAiTools();
Expand Down
Loading