refactor(router): Add handling for ActivatedRoute-scoped injector#69200
Draft
atscott wants to merge 1 commit into
Draft
refactor(router): Add handling for ActivatedRoute-scoped injector#69200atscott wants to merge 1 commit into
atscott wants to merge 1 commit into
Conversation
14b2abd to
0c889d4
Compare
Add handling in navigation for creating and destroying injectors scoped to `ActivatedRoute` life. The code for creating the injectors is certainly more complicated than it _could_ be since there's no actual feature built around this yet. Keeps as much implementation code tree-shakeable as possible: Raw size: +764 bytes Gzipped size: +182 bytes
0c889d4 to
bb75be0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add handling in navigation for creating and destroying injectors scoped to
ActivatedRoutelife.The code for creating the injectors is certainly more complicated than it could be since there's no actual feature built around this yet.
Keeps as much implementation code tree-shakeable as possible: Raw size: +764 bytes
Gzipped size: +182 bytes