fix(common): use Object.hasOwn in I18nSelectPipe to handle null-prototype and shadowed mappings#69158
Open
arturovt wants to merge 1 commit into
Open
fix(common): use Object.hasOwn in I18nSelectPipe to handle null-prototype and shadowed mappings#69158arturovt wants to merge 1 commit into
arturovt wants to merge 1 commit into
Conversation
…type and shadowed mappings `I18nSelectPipe.transform()` called `mapping.hasOwnProperty()` directly, which fails in two edge cases: - Mappings created with `Object.create(null)` have no prototype and therefore no `hasOwnProperty` method, causing a TypeError at runtime. - Mappings where a key literally named `hasOwnProperty` shadows the built-in method return incorrect results silently. Replace both call sites with `Object.hasOwn(mapping, key)`, which delegates through `Object` directly and is immune to both issues. Add two regression tests that demonstrate the broken behaviour before the fix and pass after it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I18nSelectPipe.transform()calledmapping.hasOwnProperty()directly, which fails in two edge cases:Object.create(null)have no prototype and therefore nohasOwnPropertymethod, causing a TypeError at runtime.hasOwnPropertyshadows the built-in method return incorrect results silently.Replace both call sites with
Object.hasOwn(mapping, key), which delegates throughObjectdirectly and is immune to both issues.Add two regression tests that demonstrate the broken behaviour before the fix and pass after it.