fix(docs-infra): reserve scrollbar gutter for mobile nav#69154
Merged
Conversation
JeanMeche
approved these changes
Jun 4, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening the mobile navigation hides vertical scrolling on
body, which can remove the classic scrollbar gutter on Safari/desktop setups and change the viewport width mid-animation.Root cause
The docs shell already uses
bodyas the scroll container. When the nav opens,document.body.style.overflowY = 'hidden'removes the scrollbar, so media queries around the breakpoint can see a different width.Solution
Reserve the scrollbar gutter on the existing body scroll container with
scrollbar-gutter: stable, avoiding a larger scroll-root change while keeping the current scroll-lock behavior.Fixes #69036.
Tests
corepack pnpm exec prettier --check adev/shared-docs/styles/_resets.scssnpx --yes sass@1.94.2 --no-source-map --load-path node_modules adev/shared-docs/styles/_resets.scss $env:TEMP\angular-resets.cssgit diff --check