escape anchor fragment in shadow DOM name selector#69151
Open
rootvector2 wants to merge 1 commit into
Open
Conversation
atscott
approved these changes
Jun 4, 2026
Contributor
|
Could you please update the commit message to follow the guidelines (outlined in the failing lint check) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findAnchorFromDocumentdrops the raw url fragment into[name="${target}"]for the shadow DOM lookup, so a fragment likea"]),(*(reachable through the router whenanchorScrollingis on) breaks out of the attribute selector and makesquerySelectorthrow or match unrelated nodes, and it also breaks legitimate anchor names containing a quote; wrap it inCSS.escapeso the value stays inside the selector.