Skip to content

refactor(core): harden change store access #69136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JeanMeche wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

refactor(core): harden change store access #69136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/core/src/render3/features/ng_onchanges_feature.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@

import {InputSignalNode} from '../../authoring/input/input_signal_node';
import {OnChanges} from '../../change_detection/lifecycle_hooks';
import {SimpleChange, SimpleChanges} from '../../change_detection/simple_change';
import {assertString} from '../../util/assert';
import {EMPTY_OBJ} from '../../util/empty';
import {applyValueToInputField} from '../apply_value_input_field';
import {DirectiveDef, DirectiveDefFeature} from '../interfaces/definition';
import {SimpleChange, SimpleChanges} from '../../change_detection/simple_change';

/**
* The NgOnChangesFeature decorates a component with support for the ngOnChanges
Expand Down Expand Up @@ -112,7 +112,9 @@ function ngOnChangesSetInput<T>(
const SIMPLE_CHANGES_STORE = '__ngSimpleChanges__';

function getSimpleChangesStore(instance: any): null | NgSimpleChangesStore {
return instance[SIMPLE_CHANGES_STORE] || null;
return Object.hasOwn(instance, SIMPLE_CHANGES_STORE)
? instance[SIMPLE_CHANGES_STORE] || null
: null;
}

function setSimpleChangesStore(instance: any, store: NgSimpleChangesStore): NgSimpleChangesStore {
Expand Down
Loading