refactor(devtools): combine element name and nativeElement into element object#69135
Draft
eduhmc wants to merge 1 commit into
Draft
refactor(devtools): combine element name and nativeElement into element object#69135eduhmc wants to merge 1 commit into
eduhmc wants to merge 1 commit into
Conversation
csmick
reviewed
Jun 3, 2026
| nativeElement: undefined, | ||
| element: { | ||
| tagName: ELEMENT_NAME_MAP[controlFlowBlock.type], | ||
| node: undefined, |
Contributor
There was a problem hiding this comment.
I didn't realize there was a case where a tag name could be present without an associated node. In that case, it might make more sense to leave these properties as-is.
…nt object This refactoring combines the 'element' (tagName string) and 'nativeElement' (DOM Node) properties of DevToolsNode into a single 'element' object. This cleans up the interface and makes it clearer what is serializable.
2fabe24 to
3c5267a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactoring combines the 'element' (tagName string) and 'nativeElement' (DOM Node) properties of DevToolsNode into a single 'element' object. This cleans up the interface and makes it clearer what is serializable.