fix(common): Limits date format string length#69000
Open
SkyZeroZx wants to merge 1 commit into
Open
Conversation
Introduces a maximum length of 1024 characters for date format strings. This prevents potential Denial of Service (DoS) attacks by throwing an `INVALID_DATE_FORMAT` error if an excessively long format string is provided to `formatDate` or `DatePipe`, safeguarding against performance degradation or application crashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a maximum length of 1024 characters for date format strings.
This prevents potential Denial of Service (DoS) attacks by throwing an
INVALID_DATE_FORMATerror if an excessively long format string is provided toformatDateorDatePipe, safeguarding against performance degradation or application crashes.This can be considered similar to #68840