feat(devtools): implement a signal graph nodes search#68991
Open
hawkgs wants to merge 1 commit into
Open
Conversation
Implement singal graph nodes search for easier navigation within graphs with large sets of nodes. The search provides filtering by node type via `type:<SIGNAL_TYPE>` syntax. `ng-filter`, that had been used in the directive tree, is reused and repurposed as a generic/shared component.
hawkgs
commented
May 28, 2026
| styleUrls: ['./filter.component.scss'], | ||
| imports: [MatIcon, MatTooltip], | ||
| }) | ||
| export class FilterComponent { |
Member
Author
There was a problem hiding this comment.
Changes to this component are minimal. Mainly:
- Added comments
- Updated the SCSS to enable configurability
- Added a configurable placeholder and debounce functionality
SkyZeroZx
reviewed
May 28, 2026
|
|
||
| private debounceTimeout?: ReturnType<typeof setTimeout>; | ||
|
|
||
| emitFilter(filterStr: string): void { |
Contributor
There was a problem hiding this comment.
Q: Wouldn't it be better to use signals forms and debounce? I say this without having the full context of how it interacts with other components in devtools, but I think it could simplify things a bit.
Member
Author
There was a problem hiding this comment.
I get your point. I guess that purely from semantics point of view, this filter doesn't really qualify as a form since it's rather a real-time type-to-search, and we don't strictly deal with any kind of form state management here.
I could see RxJS as an alternative here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement singal graph nodes search for easier navigation within graphs with large sets of nodes. The search provides filtering by node type via
type:<SIGNAL_TYPE>syntax.ng-filter, that is used in the directive tree, has been reused and repurposed as a generic/shared component.Screen.Recording.2026-05-28.at.19.07.45.mov