refactor(platform-server): clean up and simplify parseUrl utility - #68983
Merged
pkozlowski-opensource merged 2 commits intoMay 29, 2026
Merged
Conversation
alan-agius4
force-pushed
the
refactor-url-building-cleanup
branch
from
May 28, 2026 12:09
cbc32af to
2a31fb4
Compare
alan-agius4
force-pushed
the
refactor-url-building-cleanup
branch
4 times, most recently
from
May 28, 2026 12:29
521b25e to
2768415
Compare
alan-agius4
force-pushed
the
refactor-url-building-cleanup
branch
from
May 28, 2026 12:33
2768415 to
8be0b85
Compare
Trims leading/trailing whitespaces in resolveUrl to normalize input. Leverages the native new URL() constructor with a non-standard base (resolve://) under strict mode to detect and reject malformed absolute targets (like double ports) during bootstrap, rather than raw regular expressions. Preserves relative sub-paths safely by only collapsing consecutive leading slashes/backslashes when a slash is present, ensuring trailing-slash contexts are resolved properly against parent domains. Adds and updates comprehensive unit tests covering all relative pathing, malformed structures, and potential hijacking edge cases.
alan-agius4
force-pushed
the
refactor-url-building-cleanup
branch
from
May 28, 2026 12:35
8be0b85 to
1f3725e
Compare
alan-agius4
marked this pull request as ready for review
May 28, 2026 12:36
JeanMeche
reviewed
May 29, 2026
JeanMeche
approved these changes
May 29, 2026
alan-agius4
force-pushed
the
refactor-url-building-cleanup
branch
from
May 29, 2026 08:38
ca8cdc6 to
3e63114
Compare
Member
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trims leading/trailing whitespaces in parseUrl to normalize input.
Leverages the native new URL() constructor with a non-standard base (resolve://) under strict mode to detect and reject malformed absolute targets (like double ports) during bootstrap, rather than raw regular expressions.
Preserves relative sub-paths safely by only collapsing consecutive leading slashes/backslashes when a slash is present, ensuring trailing-slash contexts are resolved properly against parent domains.
Adds and updates comprehensive unit tests covering all relative pathing, malformed structures, and potential hijacking edge cases.