fix(migrations): Make the safe optional chaining idempotent#68975
Open
JeanMeche wants to merge 1 commit into
Open
fix(migrations): Make the safe optional chaining idempotent#68975JeanMeche wants to merge 1 commit into
JeanMeche wants to merge 1 commit into
Conversation
atscott
approved these changes
May 28, 2026
atscott
reviewed
May 28, 2026
| // --------------------------------------------------------------------------- | ||
|
|
||
| override visitCall(ast: Call, nullSensitive: boolean): any { | ||
| if (isSafeNavigationMigrationCall(ast)) { |
Contributor
There was a problem hiding this comment.
is it possible that there would be nested required calls to this? e.g. my?.utility?.service(my?.optional?.argument)? (maybe not the best example but you get the idea)
Member
Author
There was a problem hiding this comment.
I've added a test that illustrates that we're still good !
Our unit tests were missleading, the migration wasn't idempotent and `$safeNavigationMigration` were added multiple times on consecutive runs.
d29cada to
f579e1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our unit tests were missleading, the migration wasn't idempotent and
$safeNavigationMigrationwere added multiple times on consecutive runs.