refactor(docs-infra): extract magic 27 in navigation-list tooltip thr…#68960
Open
erkamyaman wants to merge 1 commit into
Open
refactor(docs-infra): extract magic 27 in navigation-list tooltip thr…#68960erkamyaman wants to merge 1 commit into
erkamyaman wants to merge 1 commit into
Conversation
…eshold The matTooltip on navigation list items was disabled when the label was shorter than the literal `27`, repeated across four bindings in the template. Lift the value to a protected readonly field so the threshold has a name and lives in one place.
JeanMeche
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The matTooltip on navigation list items was disabled when the label was shorter than the literal
27, repeated across four bindings in the template. Lift the value to a protected readonly field so the threshold has a name and lives in one place.PR Checklist
PR Type
What is the current behavior?
The
matTooltipDisabledbinding on each navigation list item compares the label length against a literal27, repeated four times across the template.What is the new behavior?
The threshold is extracted to a
protected readonly labelTruncationThreshold = 27field onNavigationListand the four template bindings reference it by name. No functional change.Does this PR introduce a breaking change?