fix(core): Handle synchronous errors in PendingTasks.run function#68956
Open
atscott wants to merge 1 commit into
Open
fix(core): Handle synchronous errors in PendingTasks.run function#68956atscott wants to merge 1 commit into
atscott wants to merge 1 commit into
Conversation
catches synchronous errors coming out of the function passed to PendingTasks.run
dgp1130
approved these changes
May 27, 2026
| const removeTask = this.add(); | ||
| fn().catch(this.errorHandler).finally(removeTask); | ||
| try { | ||
| fn().catch(this.errorHandler).finally(removeTask); |
Contributor
There was a problem hiding this comment.
Darn, I think we're just a month or two short of being able to use Promise.try: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/try
Member
There was a problem hiding this comment.
We're more than a year off: https://web-platform-dx.github.io/web-features-explorer/features/promise-try/
Contributor
There was a problem hiding this comment.
Ah I think I misremembered 1.5 years instead of 2.5 years.
Didn't know they updated that site with an expected widely available date, that's useful!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
catches synchronous errors coming out of the function passed to PendingTasks.run