fix(forms): reflect required validators in compat fields#68911
Open
KirtiRamchandani wants to merge 1 commit into
Open
fix(forms): reflect required validators in compat fields#68911KirtiRamchandani wants to merge 1 commit into
KirtiRamchandani wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
compatFormwraps reactiveFormControls, but the signal-formsrequiredstate does not reflect a wrapped control that hasValidators.required. This leavesFieldTree#requiredfalse even when the reactive control reports the required validator.Fixes #68905.
Root cause
Compat field nodes inherit
FieldNode.required, which only reads signal-formsREQUIREDmetadata. Reactive form validators on the wrappedAbstractControlare not included in that metadata.Solution
Expose
requiredfromCompatFieldNodeby deriving a signal from the wrapped control'shasValidator(Validators.required)state, using the existing control-status signal helper so validator updates and control swaps are observed.Tests run
corepack pnpm bazel test //packages/forms/signals/test/node:test --test_arg=--filter='picks up the required state from a reactive form control' --test_output=errorscorepack pnpm bazel test //packages/forms/signals/test/node:test --test_output=errorsnpx --yes prettier@3.8.3 --check packages\forms\signals\compat\src\compat_field_node.ts packages\forms\signals\test\node\compat\compat.spec.tsgit diff --check