fix(common): warn in dev mode when toDate() receives an unrecognized string format#68909
Open
arturovt wants to merge 1 commit into
Open
fix(common): warn in dev mode when toDate() receives an unrecognized string format#68909arturovt wants to merge 1 commit into
arturovt wants to merge 1 commit into
Conversation
Member
Does it though ? Our hydration process shouldn't be sensible to text changes. |
d439124 to
4255665
Compare
Contributor
Author
|
@JeanMeche you're right, i checked |
…d string format `toDate()` falls back to `new Date(value)` when the input string does not match any of Angular's supported date formats. This fallback is kept for backwards compatibility but is unsafe: non-ISO strings (e.g. `'Jan 15 2024'`) are parsed relative to the local timezone, so a server in UTC and a browser in UTC+8 will compute different `Date` values from the same string — producing inconsistent rendered output and potentially incorrect results when the date drives logic such as access-control or expiry checks. To surface this before the fallback is eventually removed, emit a `console.error` (dev mode only) that identifies the offending value and instructs callers to pass an ISO 8601 string, a numeric timestamp, or a `Date` object instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toDate()falls back tonew Date(value)when the input string does not matchany of Angular's supported date formats. This fallback is kept for backwards
compatibility but is unsafe: non-ISO strings (e.g.
'Jan 15 2024') are parsedrelative to the local timezone, so a server in UTC and a browser in UTC+8 will
compute different
Datevalues from the same string — producing inconsistentrendered output and potentially incorrect results when the date drives logic such
as access-control or expiry checks.
To surface this before the fallback is eventually removed, emit a
console.error(dev mode only) that identifies the offending value and instructs callers to pass
an ISO 8601 string, a numeric timestamp, or a
Dateobject instead.