fix(common): warn in dev mode when toDate() receives an unrecognized string format#68909
Open
arturovt wants to merge 1 commit into
Open
fix(common): warn in dev mode when toDate() receives an unrecognized string format#68909arturovt wants to merge 1 commit into
arturovt wants to merge 1 commit into
Conversation
…string format
Prior to this commit, `toDate()` silently forwarded unrecognized date strings to `new Date()` with no indication to the developer that this behavior was unsafe. The result is platform and timezone dependent — a server running in UTC and a browser in UTC+8 will produce different dates from the same input string, causing SSR hydration mismatches.
**Example:**
```js
// Browser in UTC+8 (offset 480):
new Date('Jan 15 2024').toISOString() // → 2024-01-15T08:00:00.000Z
// Server in UTC (offset 0):
new Date('Jan 15 2024').toISOString() // → 2024-01-15T00:00:00.000Z
```
The same input string produces a different date depending on where the code runs.
**The fix** adds a `console.error` in `ngDevMode` when `toDate()` receives a string that does not match any of the supported formats — ISO 8601 date-only, ISO 8601 datetime, or a numeric string. The error message tells the developer exactly which value triggered the warning and how to fix it. Production behavior is unchanged — the `new Date()` fallback still runs, so no breaking changes are introduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
toDate()silently forwarded unrecognized date strings tonew Date()with no indication to the developer that this behavior was unsafe. The result is platform and timezone dependent — a server running in UTC and a browser in UTC+8 will produce different dates from the same input string, causing SSR hydration mismatches.Example:
The same input string produces a different date depending on where the code runs.
The fix adds a
console.errorinngDevModewhentoDate()receives a string that does not match any of the supported formats — ISO 8601 date-only, ISO 8601 datetime, or a numeric string. The error message tells the developer exactly which value triggered the warning and how to fix it. Production behavior is unchanged — thenew Date()fallback still runs, so no breaking changes are introduced.