Skip to content

fix(service-worker): verify event source before processing INITIALIZE message #68898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
arturovt wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −2
Draft

fix(service-worker): verify event source before processing INITIALIZE message #68898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions packages/service-worker/worker/src/driver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,9 +309,22 @@ export class Driver implements Debuggable, UpdateSource {

event.waitUntil(
(async () => {
// Initialization is the only event which is sent directly from the SW to itself, and thus
// `event.source` is not a `Client`. Handle it here, before the check for `Client` sources.
// INITIALIZE is sent by the SW to itself on activation, so event.source is
// the SW registration (not a Client). We still verify this explicitly to
// prevent arbitrary external sources from triggering initialization.
if (data.action === 'INITIALIZE') {
// Accept INITIALIZE only from the SW itself (non-Client source) or from
// a legitimate Client — reject anything else (e.g. cross-origin iframes).
const isOwnSW =
event.source === this.scope.registration.active ||
event.source === this.scope.registration.installing ||
event.source === this.scope.registration.waiting;
const isLegitimateClient = this.adapter.isClient(event.source);

if (!isOwnSW && !isLegitimateClient) {
return;
}

return this.ensureInitialized(event);
}

Expand Down
Loading