Skip to content

fix(core): do not register dom triggers when defer blocks are in manual mode#68878

Open
crisbeto wants to merge 1 commit into
angular:mainfrom
crisbeto:68800/defer-manual
Open

fix(core): do not register dom triggers when defer blocks are in manual mode#68878
crisbeto wants to merge 1 commit into
angular:mainfrom
crisbeto:68800/defer-manual

Conversation

@crisbeto
Copy link
Copy Markdown
Member

Fixes that we were registering DOM triggers even if the @defer block is set up to be rendered manually. This matches the behavior we already have for timer triggers.

Fixes #68800.

…al mode

Fixes that we were registering DOM triggers even if the `@defer` block is set up to be rendered manually. This matches the behavior we already have for timer triggers.

Fixes angular#68800.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels May 22, 2026
@angular-robot angular-robot Bot added the area: core Issues related to the framework runtime label May 22, 2026
@ngbot ngbot Bot added this to the Backlog milestone May 22, 2026
@crisbeto crisbeto added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels May 22, 2026
@crisbeto
Copy link
Copy Markdown
Member Author

Passing TGP

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 22, 2026
@crisbeto
Copy link
Copy Markdown
Member Author

Caretaker note: presubmit failure is unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DeferBlockBehavior.Manual still registers IntersectionObserver for @defer (on viewport), breaking JSDOM tests

2 participants