Skip to content

refactor(core): extend sanitization test coverage #68847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JeanMeche wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(core): extend sanitization test coverage #68847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 45 additions & 1 deletion packages/core/test/render3/integration_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ import {TestBed} from '../../testing';

import {getLContext, readPatchedData} from '../../src/render3/context_discovery';
import {CONTEXT, HEADER_OFFSET} from '../../src/render3/interfaces/view';
import {Sanitizer} from '../../src/sanitization/sanitizer';
import {SecurityContext} from '../../src/sanitization/dom_security_schema';
import {Sanitizer} from '../../src/sanitization/sanitizer';

describe('element discovery', () => {
it('should only monkey-patch immediate child nodes in a component', () => {
Expand Down Expand Up @@ -691,6 +691,50 @@ describe('sanitization', () => {
const fixture = TestBed.createComponent(TestComp);
expect(() => fixture.detectChanges()).not.toThrow();
});

it('should throw on uppercase iframe element', () => {
@Directive({
selector: '[unsafeUrlHostBindingDir]',
host: {
'[attr.src]': '"http://src-dir-value"',
},
})
class UnsafeUrlHostBindingDir {}

@Component({
imports: [UnsafeUrlHostBindingDir],
template: ` <IFRAME unsafeUrlHostBindingDir></IFRAME>`,
changeDetection: ChangeDetectionStrategy.Eager,
})
class SimpleComp {}

const fixture = TestBed.createComponent(SimpleComp);
expect(() => fixture.detectChanges()).toThrowError(
/NG0904: unsafe value used in a resource URL/,
);
});

it('should throw on uppercase SRC attribute on iframe element', () => {
@Directive({
selector: '[unsafeUrlHostBindingDir]',
host: {
'[attr.SRC]': '"http://src-dir-value"',
},
})
class UnsafeUrlHostBindingDir {}

@Component({
imports: [UnsafeUrlHostBindingDir],
template: ` <iframe unsafeUrlHostBindingDir></iframe>`,
changeDetection: ChangeDetectionStrategy.Eager,
})
class SimpleComp {}

const fixture = TestBed.createComponent(SimpleComp);
expect(() => fixture.detectChanges()).toThrowError(
/NG0904: unsafe value used in a resource URL/,
);
});
});

class LocalSanitizedValue {
Expand Down
Loading