fix(core): sanitize meta selectors#68836
Open
JeanMeche wants to merge 2 commits into
Open
Conversation
Ensure that property/name are correctly escaped and doesn't break out of the intended selector.
de1a51b to
173f47e
Compare
173f47e to
c2dcf4e
Compare
alan-agius4
reviewed
May 21, 2026
| @@ -114,7 +115,11 @@ export class Meta { | |||
| getTags(attrSelector: string): HTMLMetaElement[] { | |||
| if (!attrSelector) return []; | |||
| const list /*NodeList*/ = this._doc.querySelectorAll(`meta[${attrSelector}]`); | |||
| return list ? [].slice.call(list) : []; | |||
| return list | |||
| ? (([].slice.call(list) as HTMLElement[]).filter( | |||
Contributor
There was a problem hiding this comment.
NIT:
Not sure why _doc in the constructor is any in this case, which does cause the need for castings.
Suggested change
| ? (([].slice.call(list) as HTMLElement[]).filter( | |
| ? ((Array.from(list) as HTMLElement[]).filter( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that property/name are correctly escaped and doesn't break out of the intended selector.