Skip to content

docs: modernize autocomplete examples and guide to signal apis#68833

Open
tjshiu wants to merge 1 commit into
angular:mainfrom
tjshiu:adev-combo
Open

docs: modernize autocomplete examples and guide to signal apis#68833
tjshiu wants to merge 1 commit into
angular:mainfrom
tjshiu:adev-combo

Conversation

@tjshiu
Copy link
Copy Markdown
Contributor

@tjshiu tjshiu commented May 20, 2026

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

Updates the autocomplete doc examples to the new combobox api.

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Currently the autocomplete examples are broken since we deprecated the old combobox api.

Issue Number: N/A

What is the new behavior?

Updates the autocomplete doc examples to the new combobox api.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@tjshiu tjshiu requested review from JeanMeche and bencodezen and removed request for bencodezen May 20, 2026 19:38
@angular-robot angular-robot Bot added the area: docs Related to the documentation label May 20, 2026
@ngbot ngbot Bot added this to the Backlog milestone May 20, 2026
@tjshiu tjshiu requested review from bencodezen and ok7sai May 20, 2026 19:38
@tjshiu tjshiu added target: major This PR is targeted for the next major release action: review The PR is still awaiting reviews from at least one requested reviewer adev: preview labels May 20, 2026
@github-actions
Copy link
Copy Markdown

Deployed adev-preview for 34688c2 to: https://ng-dev-previews-fw--pr-angular-angular-68833-adev-prev-8mlnbq23.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@tjshiu tjshiu marked this pull request as ready for review May 20, 2026 20:30
@ok7sai
Copy link
Copy Markdown
Member

ok7sai commented May 20, 2026

The overview and auto-select examples work a bit different from the dev-app in Components. Once an option is selected then removing the string from the textbox, the string restores when the focus leaves the textbox.

@tjshiu tjshiu added target: rc This PR is targeted for the next release-candidate and removed target: major This PR is targeted for the next major release labels May 20, 2026
@tjshiu
Copy link
Copy Markdown
Contributor Author

tjshiu commented May 20, 2026

Discussed offline but we will follow up with a clear button addition.

@tjshiu tjshiu added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 20, 2026
@alan-agius4 alan-agius4 removed the request for review from bencodezen May 21, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants