perf(forms): avoid redundant invalidations in parser errors signal#68830
Open
arturovt wants to merge 1 commit into
Open
perf(forms): avoid redundant invalidations in parser errors signal#68830arturovt wants to merge 1 commit into
arturovt wants to merge 1 commit into
Conversation
The `errors` linkedSignal in `createParser` had no equality check, so every reset or recomputation — even to an identical empty array — would mark downstream dependents as dirty and trigger unnecessary re-renders. Add `shallowArrayEquals` as the equality function so the signal only notifies dependents when the error list actually changes.
JeanMeche
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
errorslinkedSignal increateParserhad no equality check, so every reset or recomputation — even to an identical empty array — would mark downstream dependents as dirty and trigger unnecessary re-renders.Add
shallowArrayEqualsas the equality function so the signal only notifies dependents when the error list actually changes.