test(upgrade): exclude unit test files from E2E application sources#68791
Open
alan-agius4 wants to merge 1 commit into
Open
test(upgrade): exclude unit test files from E2E application sources#68791alan-agius4 wants to merge 1 commit into
alan-agius4 wants to merge 1 commit into
Conversation
Exclude `**/*.spec.ts` files from the `srcs` glob of the `full_sources` target. Previously, `module.spec.ts` was compiled as part of the application's main sources because the glob pattern only excluded `**/*_spec.ts` (E2E specs). Consequently, `module.spec.js` was generated and included in the runfiles of the E2E test target, causing the Protractor runner to load and execute it. This failed since the E2E testing runner does not have access to unit testing imports like `@angular/core/testing`.
JeanMeche
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude
**/*.spec.tsfiles from thesrcsglob of thefull_sourcestarget.Previously,
module.spec.tswas compiled as part of the application's main sources because the glob pattern only excluded**/*_spec.ts(E2E specs). Consequently,module.spec.jswas generated and included in the runfiles of the E2E test target, causing the Protractor runner to load and execute it. This failed since the E2E testing runner does not have access to unit testing imports like@angular/core/testing.