fix(core): do not insert todo when migrating void @Output#68781
Open
tmpln wants to merge 1 commit into
Open
Conversation
The following: `@Output() someChange = new EventEmitter<void>();` is correctly migrated to: `readonly someChange = output<void>();` However, a TODO is incorrectly inserted for subsequent emissions from `someChange`, stating that an argument is expected.
JeanMeche
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following:
@Output() someChange = new EventEmitter<void>();is correctly migrated to:
readonly someChange = output<void>();However, a TODO is incorrectly inserted for subsequent emissions from
someChange, stating that an argument is expected.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Void-emitting outputs get spurious TODO messages during migration to output function.
Issue Number: N/A
What is the new behavior?
No spurious TODO messages are inserted during migration of void outputs.
Does this PR introduce a breaking change?
Other information
N/A