Skip to content

fix(core): do not insert todo when migrating void @Output#68781

Open
tmpln wants to merge 1 commit into
angular:mainfrom
tmpln:output-void-schematics
Open

fix(core): do not insert todo when migrating void @Output#68781
tmpln wants to merge 1 commit into
angular:mainfrom
tmpln:output-void-schematics

Conversation

@tmpln
Copy link
Copy Markdown
Contributor

@tmpln tmpln commented May 18, 2026

The following:

@Output() someChange = new EventEmitter<void>();

is correctly migrated to:

readonly someChange = output<void>();

However, a TODO is incorrectly inserted for subsequent emissions from someChange, stating that an argument is expected.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Void-emitting outputs get spurious TODO messages during migration to output function.

Issue Number: N/A

What is the new behavior?

No spurious TODO messages are inserted during migration of void outputs.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N/A

The following:

`@Output() someChange = new EventEmitter<void>();`

is correctly migrated to:

`readonly someChange = output<void>();`

However, a TODO is incorrectly inserted for subsequent emissions from
`someChange`, stating that an argument is expected.
@pullapprove pullapprove Bot requested a review from atscott May 18, 2026 13:53
@angular-robot angular-robot Bot added the area: core Issues related to the framework runtime label May 18, 2026
@ngbot ngbot Bot added this to the Backlog milestone May 18, 2026
@JeanMeche JeanMeche added the target: patch This PR is targeted for the next patch release label May 18, 2026
@JeanMeche JeanMeche removed the request for review from atscott May 18, 2026 13:58
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants