fix(upgrade): support model() signals in downgradeComponent#68760
Open
arturovt wants to merge 1 commit into
Open
fix(upgrade): support model() signals in downgradeComponent#68760arturovt wants to merge 1 commit into
arturovt wants to merge 1 commit into
Conversation
`model()` signals are special because they combine a signal input with a writable output through an internal `OutputEmitterRef`. During upgrade, `setupOutputs()` subscribes to that emitter to keep Angular → AngularJS two-way binding working. The issue was that `updateInput()` could overwrite the signal property directly when `isSignal` was `false` (which happens in JIT mode and when `unsafelyOverwriteSignalInputs` is enabled). Once that happened, the original `OutputEmitterRef` was lost, so the two-way binding stopped working. The fix detects `model()` signals at runtime by checking for both `[SIGNAL]` and a writable `.set()` method, which distinguishes them from read-only `input()` signals. When those traits are present, updates are always applied through `applyValueToInputSignal()` instead of replacing the property directly, regardless of the `unsafelyOverwriteSignalInputs` setting. Fixes angular#60599
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
model()signals are special because they combine a signal input with a writable output through an internalOutputEmitterRef. During upgrade,setupOutputs()subscribes to that emitter to keep Angular → AngularJS two-way binding working.The issue was that
updateInput()could overwrite the signal property directly whenisSignalwasfalse(which happens in JIT mode and whenunsafelyOverwriteSignalInputsis enabled). Once that happened, the originalOutputEmitterRefwas lost, so the two-way binding stopped working.The fix detects
model()signals at runtime by checking for both[SIGNAL]and a writable.set()method, which distinguishes them from read-onlyinput()signals. When those traits are present, updates are always applied throughapplyValueToInputSignal()instead of replacing the property directly, regardless of theunsafelyOverwriteSignalInputssetting.Fixes #60599