refactor(router): remove unused imports#68750
Closed
erkamyaman wants to merge 1 commit into
Closed
Conversation
Drop five unused imports across four router files: `Observable` and `Params` in `router_outlet.ts`, `EnvironmentInjector` in `resolve_data.ts` and `preactivation.ts`, and `ActivatedRouteSnapshot` in `config.ts`.
Member
|
Honnestly this kind of cleanup isn't really necessary. It's better to spend time on more meaningful changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Four files in
packages/router/srcimport names they don't use:directives/router_outlet.ts:ObservablefromrxjsandParamsfrom../sharedoperators/resolve_data.ts:EnvironmentInjectorfrom@angular/coreutils/config.ts:ActivatedRouteSnapshotfrom../router_stateutils/preactivation.ts:EnvironmentInjectorfrom@angular/coreEach is unreferenced outside its import line.
What is the new behavior?
The unused imports are removed. No runtime or type-surface changes.
Does this PR introduce a breaking change?