refactor(compiler): sync compiler_facade_interface replica with main#68747
Open
erkamyaman wants to merge 1 commit into
Open
refactor(compiler): sync compiler_facade_interface replica with main#68747erkamyaman wants to merge 1 commit into
erkamyaman wants to merge 1 commit into
Conversation
The replica at packages/core/src/compiler/compiler_facade_interface.ts drifted from the main copy. The file header specifies syncing via `cp main replica`; running it fixes field-order drift and relocates `legacyOptionalChaining?: boolean;` back onto R3DeclareDirectiveFacade (it was incorrectly on R3DeclareComponentFacade in the replica).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
packages/compiler/src/compiler_facade_interface.tsandpackages/core/src/compiler/compiler_facade_interface.tsare described in the file header as two copies of the same interfaces, with an explicitcpcommand for keeping them in sync. The replica incore/has drifted from the main incompiler/:R3DirectiveMetadataFacade:isSignal/hostDirectivesfield order is reversed.R3DeclareDirectiveFacade:controlCreateformatted on multiple lines;isSignal/hostDirectivesorder reversed;legacyOptionalChaining?: boolean;is missing.R3DeclareComponentFacade: carries a duplicatelegacyOptionalChaining?: boolean;even though it already extendsR3DeclareDirectiveFacade.What is the new behavior?
The replica is brought back in sync with the main by running the exact
cpcommand the file header specifies. The drift items above are all corrected;legacyOptionalChainingis removed from the child interface and present on the parent where it inherits naturally.Does this PR introduce a breaking change?