Skip to content

refactor(compiler): sync compiler_facade_interface replica with main#68747

Open
erkamyaman wants to merge 1 commit into
angular:mainfrom
erkamyaman:refactor-compiler-sync-facade-interface-replica
Open

refactor(compiler): sync compiler_facade_interface replica with main#68747
erkamyaman wants to merge 1 commit into
angular:mainfrom
erkamyaman:refactor-compiler-sync-facade-interface-replica

Conversation

@erkamyaman
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

packages/compiler/src/compiler_facade_interface.ts and packages/core/src/compiler/compiler_facade_interface.ts are described in the file header as two copies of the same interfaces, with an explicit cp command for keeping them in sync. The replica in core/ has drifted from the main in compiler/:

  • R3DirectiveMetadataFacade: isSignal / hostDirectives field order is reversed.
  • R3DeclareDirectiveFacade: controlCreate formatted on multiple lines; isSignal / hostDirectives order reversed; legacyOptionalChaining?: boolean; is missing.
  • R3DeclareComponentFacade: carries a duplicate legacyOptionalChaining?: boolean; even though it already extends R3DeclareDirectiveFacade.

What is the new behavior?

The replica is brought back in sync with the main by running the exact cp command the file header specifies. The drift items above are all corrected; legacyOptionalChaining is removed from the child interface and present on the parent where it inherits naturally.

Does this PR introduce a breaking change?

  • Yes
  • No

The replica at packages/core/src/compiler/compiler_facade_interface.ts drifted from the main copy. The file header specifies syncing via `cp main replica`; running it fixes field-order drift and relocates `legacyOptionalChaining?: boolean;` back onto R3DeclareDirectiveFacade (it was incorrectly on R3DeclareComponentFacade in the replica).
@pullapprove pullapprove Bot requested a review from kirjs May 15, 2026 17:20
@angular-robot angular-robot Bot added the area: compiler Issues related to `ngc`, Angular's template compiler label May 15, 2026
@ngbot ngbot Bot added this to the Backlog milestone May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: compiler Issues related to `ngc`, Angular's template compiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant