fix(router): Add strict typing on 'getResolvedTitleForRoute'#68746
Open
atscott wants to merge 1 commit into
Open
fix(router): Add strict typing on 'getResolvedTitleForRoute'#68746atscott wants to merge 1 commit into
atscott wants to merge 1 commit into
Conversation
The title property in Router type already requires that the return type of a resolved title is a string. The type was looser here only because 'data' values are typed as 'any'.
crisbeto
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title property in Router type already requires that the return type of a resolved title is a string. The type was looser here only because 'data' values are typed as 'any'.
(technically could be considered breaking. If we have a green TGP I'm going to consider this not)