perf(devtools): optimize signal graph nodes value inspection#68745
Open
hawkgs wants to merge 1 commit into
Open
perf(devtools): optimize signal graph nodes value inspection#68745hawkgs wants to merge 1 commit into
hawkgs wants to merge 1 commit into
Conversation
This change is based on the presumption that a signal graph can be significantly large memory-wise sometimes. This is the reason why we don't send the full graph to the FE but rather serialize its values and then lazy load them when they are needed, that is, during value inspection. Because of the above-mentioned approach, when we inspect nested object values, we request the component's signal graph on each property expansion. This may results in a lot of redundant `ng.getSignalGraph` calls, that in the case of large graphs may have negative performance impact. The change prevents that by caching the last signal graph on the backend after the first request for nested properties. The cache is then cleared when the selected/focused component is changed.
4ae417d to
39b69aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is based on the presumption that a signal graph can be significantly large memory-wise sometimes. This is the reason why we don't send the full graph to the FE but rather serialize its values and then lazy load them when they are needed, that is, during value inspection.
Because of the above-mentioned approach, when we inspect nested object values, we request the component's signal graph on each property expansion. This may results in a lot of redundant
ng.getSignalGraphcalls, that in the case of large graphs may have negative performance impact.The change prevents that by caching the last signal graph on the backend after the first request for nested properties. The cache is then cleared when the selected/focused component is changed.