Skip to content

refactor(core): mark resource() overloads as @publicApi 22.0#68723

Merged
mattrbeck merged 1 commit into
angular:mainfrom
erkamyaman:refactor-core-resource-publicapi-tag
May 13, 2026
Merged

refactor(core): mark resource() overloads as @publicApi 22.0#68723
mattrbeck merged 1 commit into
angular:mainfrom
erkamyaman:refactor-core-resource-publicapi-tag

Conversation

@erkamyaman

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

#68253 graduated resource, rxResource, and httpResource to stable by swapping @experimental tags for @publicApi 22.0 across three files. The two resource() function overloads in packages/core/src/resource/resource.ts (lines 49 and 63) were missed and still carry @experimental 19.0. The public-API golden at goldens/public-api/core/index.api.md:1660,1665 already lists both overloads as // @public, so the JSDoc is the only thing contradicting the rest of the codebase.

What is the new behavior?

Both @experimental 19.0 tags are replaced with @publicApi 22.0, matching the pattern #68253 used in the sibling files (packages/common/http/src/resource.ts, packages/core/rxjs-interop/src/rx_resource.ts, packages/core/src/resource/api.ts).

Does this PR introduce a breaking change?

  • Yes
  • No

angular#68253 graduated `resource`, `rxResource`, and `httpResource` to stable
by swapping `@experimental` for `@publicApi 22.0` across three files.
The two `resource()` overloads in `packages/core/src/resource/resource.ts`
were missed and still carried `@experimental 19.0`. The public-api
golden already lists both overloads as `// @public`, so this aligns the
source with what the rest of the codebase reflects.
@pullapprove pullapprove Bot requested a review from kirjs May 13, 2026 21:20
@angular-robot angular-robot Bot added the area: core Issues related to the framework runtime label May 13, 2026
@ngbot ngbot Bot added this to the Backlog milestone May 13, 2026
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release target: rc This PR is targeted for the next release-candidate labels May 13, 2026
@JeanMeche JeanMeche removed the request for review from kirjs May 13, 2026 21:23
@mattrbeck mattrbeck removed the target: patch This PR is targeted for the next patch release label May 13, 2026
@mattrbeck mattrbeck merged commit 7557b33 into angular:main May 13, 2026
22 of 25 checks passed
@mattrbeck

Copy link
Copy Markdown
Member

This PR was merged into the repository. The changes were merged into the following branches:

@erkamyaman erkamyaman deleted the refactor-core-resource-publicapi-tag branch May 14, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants