refactor(forms): add a debug name to form and FormField#68716
Open
hawkgs wants to merge 1 commit into
Open
Conversation
Add a debug name to `form` and `FormField` that can be used for the clustering of all internal signal nodes in Angular DevTools. Note: Due to limitations related to the reactive nature of `FormField`, each form field gets a default index-based debug name.
hawkgs
commented
May 13, 2026
Comment on lines
262
to
267
| get required(): Signal<boolean> { | ||
| return this.metadata(REQUIRED) ?? FALSE; | ||
| return ( | ||
| this.metadata(REQUIRED) ?? | ||
| (ngDevMode ? computed(() => false, formDebugObj(this.debugName, 'FALSE')) : FALSE) | ||
| ); | ||
| } |
Member
Author
There was a problem hiding this comment.
Any objections to converting getters like this one to a readonly property in order to avoid computed recreation in dev mode on access?
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a debug name option (
debugName) toformandFormFieldthat can be used for the clustering of all internal signal nodes in Angular DevTools.Note: Due to limitations related to the reactive nature of
FormField, each form field gets a default index-based debug name.Unfortunately, I had to move a significant part of the class property definitions in the constructors due to used before initialization errors, which caused the a bigger diff.
The overall implications of keeping these debug names may have negative effects on the framework DX. I've been thinking about alternative solutions like excluding all internal FW signals by default from the signal graph consumed by DevTools, and including only those that are explicitly marked/included by the developer. This is a matter of a discussion though.