fix(compiler): report error for property/event bindings on ng-content#68715
Open
toha-marko wants to merge 1 commit into
Open
fix(compiler): report error for property/event bindings on ng-content#68715toha-marko wants to merge 1 commit into
toha-marko wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Previously, adding property bindings like [foo]="bar" or event bindings like (click)="handler()" to <ng-content> was silently ignored. These bindings have no effect since ng-content is not a real DOM element. This commit adds a compile-time error to warn the developer. Fixes angular#24259
729212e to
f825e73
Compare
Contributor
|
Minimally, this would require a migration to remove those invalid properties in order to land it. Given that the bug report has no upvotes or activity in almost a decade, I have to question whether this is worth it. |
Contributor
|
Is this maybe more appropriate as a template diagnostic or eslint? Breaking compilation on something entirely innocuous seems maybe incorrect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, adding property bindings like
[foo]="bar"or event bindings like(click)="handler()"to<ng-content>was silently ignored. These bindings have no effect since ng-content is not a real DOM element. This commit adds a compile-time error to warn the developer.Fixes #24259
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Adding property/event bindings to
<ng-content>is silently ignored by the compiler.Issue Number: #24259
What is the new behavior?
The compiler now reports an error when property or event bindings are found on
<ng-content>.