Skip to content

refactor(core): remove deprecated UNSAFE_IFRAME_ATTRS alias#68706

Open
erkamyaman wants to merge 1 commit into
angular:mainfrom
erkamyaman:refactor-core-remove-unsafe-iframe-attrs-alias
Open

refactor(core): remove deprecated UNSAFE_IFRAME_ATTRS alias#68706
erkamyaman wants to merge 1 commit into
angular:mainfrom
erkamyaman:refactor-core-remove-unsafe-iframe-attrs-alias

Conversation

@erkamyaman
Copy link
Copy Markdown
Contributor

@erkamyaman erkamyaman commented May 12, 2026 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

packages/core/src/errors.ts declares UNSAFE_IFRAME_ATTRS = -910 in the RuntimeErrorCode const enum as a @deprecated alias of UNSAFE_ATTRIBUTE_BINDING (same numeric value). It has no usages anywhere in the repo and carries a tslint:disable-next-line:no-duplicate-enum-values suppression to silence the duplicate-value warning. The alias is also listed in goldens/public-api/core/errors.api.md.

What is the new behavior?

The alias and its paired tslint suppression are removed from packages/core/src/errors.ts. UNSAFE_ATTRIBUTE_BINDING stays. The corresponding line in goldens/public-api/core/errors.api.md is updated to match.

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove Bot requested a review from kirjs May 12, 2026 22:03
@angular-robot angular-robot Bot added the area: core Issues related to the framework runtime label May 12, 2026
@ngbot ngbot Bot added this to the Backlog milestone May 12, 2026
@JeanMeche JeanMeche requested review from alan-agius4 and removed request for kirjs May 12, 2026 23:09
@pullapprove pullapprove Bot requested a review from kirjs May 12, 2026 23:09
@erkamyaman
refactor(core): remove deprecated UNSAFE_IFRAME_ATTRS alias
d6e763f 
`UNSAFE_IFRAME_ATTRS` in the `RuntimeErrorCode` enum is a `@deprecated`
alias of `UNSAFE_ATTRIBUTE_BINDING` (same value -910) with no usages
anywhere. Drop it along with the paired
`tslint:disable-next-line:no-duplicate-enum-values` suppression.
`RuntimeErrorCode` is re-exported as `ɵRuntimeErrorCode`, so the
enum's value set is not a stability commitment.
@erkamyaman erkamyaman force-pushed the refactor-core-remove-unsafe-iframe-attrs-alias branch from be6f949 to d6e763f Compare May 13, 2026 16:19
@erkamyaman
Copy link
Copy Markdown
Contributor Author

erkamyaman commented May 13, 2026

Pushed an update: UNSAFE_IFRAME_ATTRS was also listed in
goldens/public-api/core/errors.api.md, which is why
//packages/core:core_errors failed. The golden is now updated to match
the source and the target passes locally.

The breaking changes label is correct as a result, though the impact is
minimal: the alias was @deprecated, has no in-repo usages, and shared
its numeric value (-910) with UNSAFE_ATTRIBUTE_BINDING. Happy to
close if the team would rather keep it.

@alan-agius4
Copy link
Copy Markdown
Contributor

alan-agius4 commented May 13, 2026

Let’s see what @AndrewKushnir thinks.

@alan-agius4 alan-agius4 requested review from AndrewKushnir and removed request for kirjs May 13, 2026 18:17
@AndrewKushnir AndrewKushnir requested review from JeanMeche and removed request for AndrewKushnir May 13, 2026 18:36
@AndrewKushnir
Copy link
Copy Markdown
Contributor

AndrewKushnir commented May 13, 2026

Let’s see what @AndrewKushnir thinks.

@JeanMeche would have the latest info on this (based on an internal discussion).

@JeanMeche
Copy link
Copy Markdown
Member

JeanMeche commented May 13, 2026

Since this alias was being renamed. I think we're good to go with the removal of that deprecated entry. (The code is still use in the enum)

@pullapprove pullapprove Bot requested review from JeanMeche and kirjs May 13, 2026 19:16
JeanMeche
JeanMeche approved these changes May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

This isn't a Public API change. We're good to go for v22.

@JeanMeche JeanMeche added the target: rc This PR is targeted for the next release-candidate label May 13, 2026
@JeanMeche JeanMeche removed request for alan-agius4 and kirjs May 13, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees

No one assigned

Labels

area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@erkamyaman @alan-agius4 @AndrewKushnir @JeanMeche