refactor(compiler): support matching template elements to foreign components#68674
Draft
leonsenft wants to merge 6 commits into
Draft
refactor(compiler): support matching template elements to foreign components#68674leonsenft wants to merge 6 commits into
leonsenft wants to merge 6 commits into
Conversation
Creates the foreign view mechanism to support standard ViewContainerRef using a dedicated ɵForeignViewRef implementation. Updates tests to use public APIs (vcr.detach and vcr.insert), asserts on total innerHTML, and exports ɵForeignViewRef privately from core.
This adds the new (internal) `applyForeignNodes()` function to the bundle goldens.
- Added the ForeignComponent type in @angular/core. - Added Component.foreignImports for importing ForeignComponents. - Updated the compiler to handle ForeignComponent in template dependencies. - Updated ngtsc to extract foreignImports from standalone components. Note the compiler doesn't do anything yet with these imports.
- Added the ForeignComponent type in @angular/core. - Added Component.foreignImports for importing ForeignComponents. - Updated the compiler to handle ForeignComponent in template dependencies. - Updated ngtsc to extract foreignImports from standalone components. Note the compiler doesn't do anything yet with these imports.
…ponents We extract the identifier name from the `foreignImports` expression in `ComponentDecoratorHandler` and use a `SelectorlessMatcher` to match element tags against these names during template binding in `R3TargetBinder`. If an element matches both a regular Angular directive and a foreign component, a conflict error is thrown.
4f1461e to
ef66ea2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently based on #68643
We extract the identifier name from the
foreignImportsexpression inComponentDecoratorHandlerand use aSelectorlessMatcherto match element tags against these names during template binding inR3TargetBinder. If an element matches both a regular Angular directive and a foreign component, a conflict error is thrown.