Skip to content

docs(docs-infra): add background to playground template dropdown#68218

Merged
kirjs merged 1 commit intoangular:mainfrom
erkamyaman:fix/docs-infra-playground-dropdown-transparent-background
Apr 15, 2026
Merged

docs(docs-infra): add background to playground template dropdown#68218
kirjs merged 1 commit intoangular:mainfrom
erkamyaman:fix/docs-infra-playground-dropdown-transparent-background

Conversation

@erkamyaman
Copy link
Copy Markdown
Contributor

The template dropdown menu had no background color on the container, causing page content to bleed through behind menu items.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

It can be seen in https://angular.dev/playground?templateId=0-hello-world

The playground template dropdown (ul.adev-template-dropdown) has no background color set on the container. Only the individual buttons inside each list item have a background. This causes page content to bleed through the dropdown, visible between menu items and at the edges.

To be honest, I first thought the separator was missing between 'Hello Word' and Signals template
Screenshot 2026-04-15 at 14 51 18

and then I tried to check it in a smaller width (766px) then I saw that there is no actual separator between elements just a background issue. Between 'Control flow' and 'Minigame' template there is some blue can be seen because of the element behind it.
image

Issue Number: N/A

What is the new behavior?

The dropdown container now has background: var(--page-background), preventing any content behind it from showing through.

image image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

The template dropdown menu had no background color on the container,
causing page content to bleed through behind menu items.
@pullapprove pullapprove bot requested a review from alan-agius4 April 15, 2026 12:02
@angular-robot angular-robot bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Apr 15, 2026
@ngbot ngbot bot modified the milestone: Backlog Apr 15, 2026
@JeanMeche JeanMeche requested review from JeanMeche and removed request for alan-agius4 April 15, 2026 12:22
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 15, 2026
@kirjs kirjs merged commit b2cff79 into angular:main Apr 15, 2026
28 checks passed
@kirjs
Copy link
Copy Markdown
Contributor

kirjs commented Apr 15, 2026

This PR was merged into the repository. The changes were merged into the following branches:

@github-actions
Copy link
Copy Markdown

Deployed adev-preview for 2641bc0 to: https://ng-dev-previews-fw--pr-angular-angular-68218-adev-prev-qoiiha1e.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@erkamyaman erkamyaman deleted the fix/docs-infra-playground-dropdown-transparent-background branch April 15, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants