Skip to content

fix(http): Don't on Passthru outside of reactive context#68204

Open
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:passthru
Open

fix(http): Don't on Passthru outside of reactive context#68204
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:passthru

Conversation

@JeanMeche
Copy link
Copy Markdown
Member

Priori to this change, the InMemory API threw when request was emited outside an injection context and that request hit the passThru. This commit fixes this.

@JeanMeche
Copy link
Copy Markdown
Member Author

cc @DeborahK @SanderElias

@angular-robot angular-robot bot added the area: common/http Issues related to HTTP and HTTP Client label Apr 14, 2026
@ngbot ngbot bot added this to the Backlog milestone Apr 14, 2026
@JeanMeche JeanMeche added target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release labels Apr 14, 2026
Priori to this change, the InMemory API threw when request was emited outside an injection context and that request hit the passThru.
This commit fixes this.
Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Apr 14, 2026
@SanderElias
Copy link
Copy Markdown
Contributor

Cool, that's exactly the fix I landed on 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: common/http Issues related to HTTP and HTTP Client target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants