Adds deep linking component from Chrome Performance panel#68201
Open
SkyZeroZx wants to merge 2 commits intoangular:mainfrom
Open
Adds deep linking component from Chrome Performance panel#68201SkyZeroZx wants to merge 2 commits intoangular:mainfrom
SkyZeroZx wants to merge 2 commits intoangular:mainfrom
Conversation
Introduces unique, IDs for component instances during profiling. Embeds these instance IDs into custom `angular-devtools://component/ID` URLs for component and lifecycle hook events recorded in Chrome's Performance panel. This allows users, when deep linking is enabled, to click on a component event in the timeline summary and navigate directly to that specific component instance in the Angular DevTools extension. Closes angular#63960
Enables direct navigation to Angular components from the Chrome Performance panel's flame graph.
This feature integrates Angular DevTools with Chrome's `setOpenResourceHandler` by registering a custom URL scheme (`angular-devtools://component/{instanceId}`).
Closes angular#63960
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables direct navigation to Angular components from the Chrome Performance panel's flame graph.
This feature integrates Angular DevTools with Chrome's
setOpenResourceHandlerby registering a custom URL scheme (angular-devtools://component/{instanceId}).Closes #63960
What is the new behavior?
Using the
chrome://flags/#enable-devtools-deep-link-via-extensibility-apiflag, we enabled deep linking in the Performance panel, allowing navigation to the corresponding component.demo.mp4
Other information
I'm just unsure whether we should show the generated component ID or hide it. I think it's probably fine to leave it as is if we specify it's only for the performance panel.