feat(forms): pass SubmitEvent to FormSubmitOptions.action#68198
Open
volkanfilazi wants to merge 2 commits intoangular:mainfrom
Open
feat(forms): pass SubmitEvent to FormSubmitOptions.action#68198volkanfilazi wants to merge 2 commits intoangular:mainfrom
volkanfilazi wants to merge 2 commits intoangular:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
784b66f to
4e9ff94
Compare
459c2ec to
f77cd6a
Compare
feat(forms): pass SubmitEvent to FormSubmitOptions.action Allow submit action callbacks to access the SubmitEvent that triggered the form submission. This enables identifying the submitter button via event.submitter. Closes angular#67334 fixed test fails and added missing event changes goldens form signal index api has been updated
f77cd6a to
4569dc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow submit action callbacks to access the SubmitEvent that triggered the form submission.
This enables identifying the submitter button via event.submitter.
Closes #67334
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The submit action defined in FormSubmitOptions does not have access
to the SubmitEvent that triggered the form submission.
This makes it impossible to determine which submit button triggered
the form when multiple submit buttons are present.
Issue Number: #67334
What is the new behavior?
The submit action now receives the SubmitEvent as a third argument.
This allows accessing event.submitter to identify which button
triggered the form submission.
Does this PR introduce a breaking change?
Other information