Skip to content

refactor(http): Make BrowserXhr/XhrFactory tree-shakable#68150

Merged
kirjs merged 1 commit intoangular:mainfrom
JeanMeche:xhr-factory-tree-shaking
Apr 13, 2026
Merged

refactor(http): Make BrowserXhr/XhrFactory tree-shakable#68150
kirjs merged 1 commit intoangular:mainfrom
JeanMeche:xhr-factory-tree-shaking

Conversation

@JeanMeche
Copy link
Copy Markdown
Member

#58212 made the FetchBackend the default, we shouldn't load anything Xhr related by default anymroe.

@JeanMeche JeanMeche requested a review from AndrewKushnir April 12, 2026 11:11
@pullapprove pullapprove bot requested a review from kirjs April 12, 2026 11:11
@angular-robot angular-robot bot added the area: common/http Issues related to HTTP and HTTP Client label Apr 12, 2026
@ngbot ngbot bot added this to the Backlog milestone Apr 12, 2026
3bc095d made the `FetchBackend` the default, we shouldn't load anything Xhr related by default anymroe.
@JeanMeche JeanMeche force-pushed the xhr-factory-tree-shaking branch from baa081b to 67034ec Compare April 12, 2026 11:24
@pullapprove pullapprove bot requested a review from devversion April 12, 2026 18:11
Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Apr 12, 2026
@JeanMeche
Copy link
Copy Markdown
Member Author

caretaker note: Presubmit failure is a flake, this is good to go !

@kirjs kirjs merged commit 70368ea into angular:main Apr 13, 2026
23 of 25 checks passed
@kirjs
Copy link
Copy Markdown
Contributor

kirjs commented Apr 13, 2026

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: common/http Issues related to HTTP and HTTP Client merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants