docs(docs-infra): fix homepage nav overlay and banner visibility between 701–900px#68098
docs(docs-infra): fix homepage nav overlay and banner visibility between 701–900px#68098erkamyaman wants to merge 1 commit intoangular:mainfrom
Conversation
|
Deployed adev-preview for d4129a7 to: https://ng-dev-previews-fw--pr-angular-angular-68098-adev-prev-348uu0se.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
…een 701–900px The homepage navigation bar rendered with `height: 0` on viewports between 701–900px, causing its content to overflow on top of the announcement banner and block scrolling. Reset nav height to `auto` at tablet sizes, center the v21 banner, adjust its top margin, and hide the redundant search field since the nav bar already provides one.
ad4313c to
d4129a7
Compare
|
It is possible adjust the space around the menù? Is not align with other space elements in page. Collides on the edge 
|
Good call! Definitely, it can be done but it is pre-existing. Since this card is about another issue, let's see what the caretaker has to say. Thank you! |
|
Yeah let's make another PR for that ! |
| margin-top: 4rem; | ||
| } | ||
|
|
||
| @include mq.for-phone-only { |
There was a problem hiding this comment.
Caretaker note:
This is added to keep the mobile margin the same.
|
We have another issue with the tab selection which misplaced between 700 and 750px 
|
There is indeed this issue here! My frontend eyes failed me to see it. It seems pre-existing. But since it's related to this PR, I will have a look at it. Thank you! |
docs(docs-infra): fix homepage nav overlay and banner visibility between 701–900px
The homepage navigation bar rendered with
height: 0on viewports between 701–900px, causing its content to overflow on top of the announcement banner and block scrolling. Reset nav height toautoat tablet sizes, center the v21 banner, adjust its top margin, and hide the redundant search field since the nav bar already provides one.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Between 701–900px viewport width, the homepage navigation renders with
height: 0while its content overflows, covering the "Angular v21 is here!" banner and blocking page scrolling. The search field is also redundantly shown alongside the nav bar's own search.Issue Number: #68087
What is the new behavior?
after.mov
search field
before
after
Does this PR introduce a breaking change?
Other information