Skip to content

docs: document hydration completion check for e2e tests#68082

Closed
splincode wants to merge 1 commit intoangular:mainfrom
splincode:splincode/docs-hydration
Closed

docs: document hydration completion check for e2e tests#68082
splincode wants to merge 1 commit intoangular:mainfrom
splincode:splincode/docs-hydration

Conversation

@splincode
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the new behavior?

Add guidance to the hydration guide so E2E tests can reliably wait for client-side hydration to complete by observing the removal of Angular's temporary ngh attributes on component hosts.

Does this PR introduce a breaking change?

  • Yes
  • No

Add guidance to the hydration guide so E2E tests can reliably wait for client-side hydration to complete by observing the removal of Angular's temporary ngh attributes on component hosts.
@pullapprove pullapprove bot requested a review from devversion April 8, 2026 13:46
@angular-robot angular-robot bot added the area: docs Related to the documentation label Apr 8, 2026
@ngbot ngbot bot added this to the Backlog milestone Apr 8, 2026
@thePunderWoman
Copy link
Copy Markdown
Contributor

I don't think we'd want to recommend this. The ngh attribute is not public api and while we don't expect it'll change, we don't want people relying on things like ngh in unit tests or e2e tests. Thank you though!

@splincode splincode deleted the splincode/docs-hydration branch April 10, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: docs Related to the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants