Skip to content

fix(vscode-extension): restore correct highlighting#68067

Merged
atscott merged 1 commit intoangular:mainfrom
JeanMeche:fix-highlighting
Apr 7, 2026
Merged

fix(vscode-extension): restore correct highlighting#68067
atscott merged 1 commit intoangular:mainfrom
JeanMeche:fix-highlighting

Conversation

@JeanMeche
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche commented Apr 7, 2026

This is a regression introduced by #66891 when trying to support commenting attribute via the language service extension

This is a regression introduced by angular#66891 when trying to support commenting attribute via the language service extension
@JeanMeche JeanMeche requested a review from atscott April 7, 2026 18:32
@angular-robot angular-robot bot added the area: vscode-extension Issues related to the Angular Language Service VsCode extension label Apr 7, 2026
@ngbot ngbot bot added this to the Backlog milestone Apr 7, 2026
@atscott atscott added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Apr 7, 2026
@atscott atscott merged commit e95d846 into angular:main Apr 7, 2026
24 of 26 checks passed
@atscott
Copy link
Copy Markdown
Contributor

atscott commented Apr 7, 2026

This PR was merged into the repository. The changes were merged into the following branches:

JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 8, 2026
This change allows to toggle attributes that are on their own line and have a 1+ leading space.

This change doesn't suffer from the issue that was reverted in angular#68067.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: vscode-extension Issues related to the Angular Language Service VsCode extension target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants