Skip to content

Another approach to bootstrap Angular under a shadow root #67947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kirjs merged 5 commits into from
Apr 10, 2026
Merged

Another approach to bootstrap Angular under a shadow root #67947

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cc623aa
refactor(core): move `SharedStylesHost` interface into `@angular/core…
dgp1130 Jan 28, 2026
003f198
refactor(core): add `getRootNode` to `RNode` interface
dgp1130 Feb 19, 2026
8ff9efd
refactor(core): don't duplicate styles when adding the same host mult…
dgp1130 Apr 6, 2026
b2ad786
feat(core): support bootstrapping Angular applications underneath sha…
dgp1130 Mar 30, 2026
e4bbecc
test(platform-browser): verify that Angular supports bootstrapping un…
dgp1130 Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(core): don't duplicate styles when adding the same host mult… 
…iple times

This shouldn't have been happening before, but now that we're going to start calling `addHost` during root component boostrap, we may call `addHost` on the same node multiple times and don't want to duplicate styles.
  • Loading branch information
@dgp1130
dgp1130 committed Apr 9, 2026
commit 8ff9efd4553afe1fa3a205991951dea8ca9d74b4
2 changes: 2 additions & 0 deletions packages/platform-browser/src/dom/shared_styles_host.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,8 @@ export class SharedStylesHost implements ɵSharedStylesHost, OnDestroy {
}

addHost(hostNode: Node): void {
if (this.hosts.has(hostNode)) return;

this.hosts.add(hostNode);
Comment thread
dgp1130 marked this conversation as resolved.

// Add existing styles to new host
Expand Down
16 changes: 16 additions & 0 deletions packages/platform-browser/test/dom/shared_styles_host_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,14 @@ describe('SharedStylesHost', () => {
expect(doc.head.innerHTML).toContain('<style ng-style-reused="">a {};</style>');
expect(doc.head.innerHTML).not.toContain('ng-app-id');
});

it('should not duplicate styles when the same host is added multiple times', () => {
ssh.addStyles(['a {};']);
ssh.addHost(doc.head);
ssh.addHost(doc.head);

expect(doc.head.querySelectorAll('style')).toHaveSize(1);
});
});

describe('external', () => {
Expand Down Expand Up @@ -141,6 +149,14 @@ describe('SharedStylesHost', () => {
);
expect(doc.head.innerHTML).not.toContain('ng-app-id');
});

it('should not duplicate styles when the same host is added multiple times', () => {
ssh.addStyles([], ['component-1.css']);
ssh.addHost(doc.head);
ssh.addHost(doc.head);

expect(doc.head.querySelectorAll('link')).toHaveSize(1);
});
});

describe('removeHost', () => {
Expand Down