Repository navigation
feat(forms): support binding null to number input #66917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
72a1a9e
fix(forms): clear parse errors when model updates
mmalerba 1bd6829
feat(forms): add parsing support to native inputs
mmalerba 35ef7ea
feat(forms): support binding null to number input
mmalerba 1f91072
fixup! feat(forms): support binding null to number input
mmalerba 75d1b58
fixup! feat(forms): support binding null to number input
mmalerba 338645a
refactor(forms): extract common parser logic
mmalerba ad38f8a
fixup! refactor(forms): extract common parser logic
mmalerba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| /** | ||
| * @license | ||
| * Copyright Google LLC All Rights Reserved. | ||
| * | ||
| * Use of this source code is governed by an MIT-style license that can be | ||
| * found in the LICENSE file at https://angular.dev/license | ||
| */ | ||
|
|
||
| import {type Signal, linkedSignal} from '@angular/core'; | ||
| import type {ValidationError} from '../api/rules'; | ||
| import type {ParseResult} from '../api/transformed_value'; | ||
|
|
||
| /** | ||
| * An object that handles parsing raw UI values into model values. | ||
| */ | ||
| export interface Parser<TRaw> { | ||
| /** | ||
| * Errors encountered during the last parse attempt. | ||
| */ | ||
| errors: Signal<readonly ValidationError.WithoutFieldTree[]>; | ||
| /** | ||
| * Parses the given raw value and updates the underlying model value if successful. | ||
| */ | ||
| setRawValue: (rawValue: TRaw) => void; | ||
| } | ||
|
|
||
| /** | ||
| * Creates a {@link Parser} that synchronizes a raw value with an underlying model value. | ||
| * | ||
| * @param getValue Function to get the current model value. | ||
| * @param setValue Function to update the model value. | ||
| * @param parse Function to parse the raw value into a {@link ParseResult}. | ||
| * @returns A {@link Parser} instance. | ||
| */ | ||
| export function createParser<TValue, TRaw>( | ||
| getValue: () => TValue, | ||
| setValue: (value: TValue) => void, | ||
| parse: (raw: TRaw) => ParseResult<TValue>, | ||
| ): Parser<TRaw> { | ||
| const errors = linkedSignal({ | ||
| source: getValue, | ||
| computation: () => [] as readonly ValidationError.WithoutFieldTree[], | ||
| }); | ||
|
|
||
| const setRawValue = (rawValue: TRaw) => { | ||
| const result = parse(rawValue); | ||
| errors.set(result.errors ?? []); | ||
| if (result.value !== undefined) { | ||
| setValue(result.value); | ||
| } | ||
| }; | ||
|
|
||
| return {errors: errors.asReadonly(), setRawValue}; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.