Skip to content

refactor(compiler): remove unnecessary sanitization for safe attributes#66068

Merged
AndrewKushnir merged 2 commits into
angular:mainfrom
alan-agius4:clean-dom-security-schema-resubmit
Dec 15, 2025
Merged

refactor(compiler): remove unnecessary sanitization for safe attributes#66068
AndrewKushnir merged 2 commits into
angular:mainfrom
alan-agius4:clean-dom-security-schema-resubmit

Conversation

@alan-agius4
Copy link
Copy Markdown
Contributor

@alan-agius4 alan-agius4 commented Dec 15, 2025

Resubmit of #65753 (comment)

@alan-agius4
refactor(compiler): remove unnecessary sanitization for safe attributes
a55a432 
Remove sanitization for attributes that cannot execute code (e.g. `javascript: URIs`).
@alan-agius4 alan-agius4 marked this pull request as draft December 15, 2025 07:58
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Dec 15, 2025
@angular-robot angular-robot Bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Dec 15, 2025
@ngbot ngbot Bot added this to the Backlog milestone Dec 15, 2025
@alan-agius4 alan-agius4 added the action: global presubmit The PR is in need of a google3 global presubmit label Dec 15, 2025
@alan-agius4 alan-agius4 force-pushed the clean-dom-security-schema-resubmit branch from 7221b89 to a99c2c8 Compare December 15, 2025 12:57
@alan-agius4
Copy link
Copy Markdown
Contributor Author

alan-agius4 commented Dec 15, 2025 •
edited
Loading

TGP
TGP Deflake

@alan-agius4 alan-agius4 added PullApprove: disable action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Dec 15, 2025
@alan-agius4
Copy link
Copy Markdown
Contributor Author

alan-agius4 commented Dec 15, 2025

caretaker note:

  • presubmit failures are pre-existing
  • pullapprove has been disabled as this is a re-submit of the original PR.

@alan-agius4 alan-agius4 marked this pull request as ready for review December 15, 2025 15:48
@AndrewKushnir AndrewKushnir removed the action: global presubmit The PR is in need of a google3 global presubmit label Dec 15, 2025
@AndrewKushnir AndrewKushnir merged commit d4111ee into angular:main Dec 15, 2025
25 checks passed
@AndrewKushnir
Copy link
Copy Markdown
Contributor

AndrewKushnir commented Dec 15, 2025

This PR was merged into the repository. The changes were merged into the following branches:

@JeanMeche JeanMeche mentioned this pull request Jan 5, 2026
Closed
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Jan 15, 2026

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jan 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note PullApprove: disable target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@alan-agius4 @AndrewKushnir