Skip to content

Fix bootstrapping inside shadow roots #66048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dgp1130 wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fix bootstrapping inside shadow roots #66048

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ea5d430
refactor(core): add `StyleRoot` concept
dgp1130 Nov 6, 2025
6253eac
refactor(core): add Shadow DOM APIs to `RNode` and `RElement`
dgp1130 Nov 6, 2025
65cbb53
refactor(core): add `RNode.prototype.isConnected`
dgp1130 Nov 25, 2025
691199a
refactor(core): add `shadowRoot` to the renderer interfaces
dgp1130 Dec 11, 2025
46beccb
refactor(core): add `applyStyles` to the renderer interfaces
dgp1130 Nov 4, 2025
0ab3817
refactor(core): add `walkDescendants` utility
dgp1130 Nov 25, 2025
1087c0d
refactor(core): add `getStyleRoot`
dgp1130 Nov 26, 2025
1a644c8
fix(core): apply and remove stylesheets based on containing `StyleRoot`
dgp1130 Dec 11, 2025
1ced740
test(core): test bootstrapping an application within a shadow root
dgp1130 Dec 12, 2025
69a1a81
wip: iterating on tests
dgp1130 Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(core): add Shadow DOM APIs to RNode and RElement 
This exposes [`Node.prototype.getRootNode`](https://developer.mozilla.org/en-US/docs/Web/API/Node/getRootNode) and [`Element.prototype.shadowRoot`](https://developer.mozilla.org/en-US/docs/Web/API/Element/shadowRoot) to the framework.
  • Loading branch information
@dgp1130
dgp1130 committed Jan 20, 2026
commit 6253eac3d4d0defdb1818d181f54c12445df0117
11 changes: 11 additions & 0 deletions packages/core/src/render3/interfaces/renderer_dom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,16 @@ export interface RNode {
* Used exclusively for building up DOM which are static (ie not View roots)
*/
appendChild(newChild: RNode): RNode;

/**
* Get the root node of the DOM tree containing the node.
*
* This is typically either the `document` object (when the Node exists in light
* DOM) or a `ShadowRoot` (when the Node exists in shadow DOM).
*
* @see https://developer.mozilla.org/en-US/docs/Web/API/Node/getRootNode
*/
getRootNode(options?: GetRootNodeOptions): Node;
}

/**
Expand All @@ -78,6 +88,7 @@ export interface RElement extends RNode {
removeEventListener(type: string, listener?: EventListener, options?: boolean): void;
remove(): void;
setProperty?(name: string, value: any): void;
shadowRoot: ShadowRoot | null;
}

export interface RCssStyleDeclaration {
Expand Down