Skip to content

Allows transforms on FormUiControl signals#65760

Merged
pkozlowski-opensource merged 1 commit into
angular:mainfrom
SkyZeroZx:refactor/signal-form-transform-input
Dec 3, 2025
Merged

Allows transforms on FormUiControl signals#65760
pkozlowski-opensource merged 1 commit into
angular:mainfrom
SkyZeroZx:refactor/signal-form-transform-input

Conversation

@SkyZeroZx

@SkyZeroZx SkyZeroZx commented Dec 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

… FormUiControl interface

This change provides more flexibility in handling input signals, allowing for transformations to be applied directly within the signal.

Fixes #65756

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #65756

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ngbot ngbot Bot added this to the Backlog milestone Dec 1, 2025
@SkyZeroZx SkyZeroZx force-pushed the refactor/signal-form-transform-input branch from 9e50327 to 584dce4 Compare December 1, 2025 17:35
@SkyZeroZx SkyZeroZx changed the title refactor(forms): replace InputSignal with InputSignalWithTransform in… Allows transforms on FormUiControl signals Dec 1, 2025
@SkyZeroZx SkyZeroZx force-pushed the refactor/signal-form-transform-input branch from 584dce4 to 4bf9926 Compare December 1, 2025 18:15
@SkyZeroZx SkyZeroZx marked this pull request as ready for review December 1, 2025 18:16
@pullapprove pullapprove Bot requested a review from crisbeto December 1, 2025 18:16
@JeanMeche JeanMeche requested a review from mmalerba December 1, 2025 18:23
mmalerba
mmalerba approved these changes Dec 1, 2025
View reviewed changes

@mmalerba mmalerba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a nice DX improvement

@pullapprove pullapprove Bot requested a review from JeanMeche December 1, 2025 20:19
JeanMeche
JeanMeche approved these changes Dec 1, 2025
View reviewed changes

@JeanMeche JeanMeche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 1, 2025
@JeanMeche JeanMeche removed the request for review from crisbeto December 1, 2025 20:20
@mmalerba

mmalerba commented Dec 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Can you change the commit to feat, now that signal forms is out we want to track individual features in the changelog instead of just lumping them all under the launch as refactor commits.

caretaker: this is a feature for an experimental API, ok to land in patch

@mmalerba mmalerba added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: merge The PR is ready for merge by the caretaker labels Dec 1, 2025
@SkyZeroZx
feat(forms): Allows transforms on FormUiControl signals
dba0951 
Extends the `FormUiControl` interface to allow `InputSignalWithTransform` in addition to `InputSignal` for its properties.

Fixes angular#65756
@SkyZeroZx SkyZeroZx force-pushed the refactor/signal-form-transform-input branch from 4bf9926 to dba0951 Compare December 1, 2025 20:22
@angular-robot angular-robot Bot added the detected: feature PR contains a feature commit label Dec 1, 2025
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker forms: signals and removed detected: feature PR contains a feature commit labels Dec 1, 2025
@pkozlowski-opensource pkozlowski-opensource merged commit 7d1e502 into angular:main Dec 3, 2025
24 checks passed
@pkozlowski-opensource

pkozlowski-opensource commented Dec 3, 2025

Copy link
Copy Markdown
Member

This PR was merged into the repository. The changes were merged into the following branches:

@JeanMeche JeanMeche mentioned this pull request Dec 5, 2025
Closed
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jan 3, 2026

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jan 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes
+1 more reviewer
@mmalerba mmalerba mmalerba approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: forms forms: signals merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

Experimental Signal Forms
Status: Done

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Signal Forms: FormUiControl doesn't allow for inputs with transform

4 participants

@SkyZeroZx @mmalerba @pkozlowski-opensource @JeanMeche