#64938 isn't even merged, that changes is too premature ATM.

#64938 isn't even merged, that changes is too premature ATM.

As I understand it, runGuardsAndResolvers (which currently supports a function with from and to RunGuardsAndResolvers ) has existed for a while, just like matcher.
The DevTools simply expose its metadata to make it easier to inspect in the router viewer.
The PR (from what I briefly reviewed) adds DI support for runGuardsAndResolvers functions, which remains backward-compatible with the existing behavior.

I shouldn't be reviewing PRs so late, you're right.

Will take over the review since Alex is not available.

Question :
When a matcher is used, the path property is not allowed. However, in the router viewer, it currently displays as /undefined.
We should consider replacing /undefined with a more descriptive label.

Yeah, that's something that we should handle.

Question :
When a matcher is used, the path property is not allowed. However, in the router viewer, it currently displays as /undefined.
We should consider replacing /undefined with a more descriptive label.

Yeah, that's something that we should handle.

I think something like this is useful to indicate that when using a matcher or other router details, the [Matcher] should be used if it exists ( property ) .
Avoid relying on the function’s name, because inline functions may not have one. ( And [Function] it's too generic )

Yeah, let's have [Matcher]. It will definitely be better than undefined. It might look a bit odd when "show full paths" is enabled, but I don't think there are other quick and better alternatives at this stage.

@SkyZeroZx, we'll need a rebase since there is a conflict. Other than that, LGTM 👍

This PR was merged into the repository. The changes were merged into the following branches:

• main: ed0647d

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}