Skip to content

fix(core): pass element removal property through in all locations #64565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thePunderWoman wants to merge 1 commit into from
Closed

fix(core): pass element removal property through in all locations #64565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(core): pass element removal property through in all locations 
The `requireSynchronousElementRemoval` property was not being passed in all the locations it was needed. This was preventing leave animation timing from behaving properly in some cases.

fixes: #64525
  • Loading branch information
@thePunderWoman
thePunderWoman committed Oct 21, 2025
commit 759eb92c075442b76a1a262e197a95514413b335
2 changes: 1 addition & 1 deletion packages/animations/browser/src/render/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export class BaseAnimationRenderer implements Renderer2 {
// Elements using the new `animate.leave` API require synchronous removal and should
// skip the rest of the legacy animation behaviors.
if (requireSynchronousElementRemoval) {
this.delegate.removeChild(parent, oldChild, isHostElement);
this.delegate.removeChild(parent, oldChild, isHostElement, requireSynchronousElementRemoval);
return;
}
// Prior to the changes in #57203, this method wasn't being called at all by `core` if the child
Expand Down
9 changes: 7 additions & 2 deletions packages/platform-browser/animations/async/src/async_animation_renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,13 @@ export class DynamicDelegationRenderer implements Renderer2 {
this.delegate.insertBefore(parent, newChild, refChild, isMove);
}

removeChild(parent: any, oldChild: any, isHostElement?: boolean | undefined): void {
this.delegate.removeChild(parent, oldChild, isHostElement);
removeChild(
parent: any,
oldChild: any,
isHostElement?: boolean | undefined,
requireSynchronousElementRemoval?: boolean,
): void {
this.delegate.removeChild(parent, oldChild, isHostElement, requireSynchronousElementRemoval);
}

selectRootElement(selectorOrNode: any, preserveContent?: boolean | undefined): any {
Expand Down