Several changes to the vscode extension build and release pipeline #64306
Closed
alan-agius4 wants to merge 4 commits into
Closed
Several changes to the vscode extension build and release pipeline #64306alan-agius4 wants to merge 4 commits into
alan-agius4 wants to merge 4 commits into
Conversation
b299e58 to
69085f7
Compare
0e5e091 to
744b1a4
Compare
devversion
approved these changes
Oct 9, 2025
| const queryPackagesCmd = | ||
| `${bazelCmd} query --output=label "filter(':npm_package$', ` + | ||
| `attr('tags', '\\[.*${releaseTargetTag}.*\\]', //packages/...))"`; | ||
| `attr('tags', '\\[.*${releaseTargetTag}.*\\]', //packages/... + //vscode-ng-language-service/...))"`; |
Member
There was a problem hiding this comment.
Maybe the whole package should have gone into packages/misc 😄
Contributor
Author
There was a problem hiding this comment.
Idk, maybe @josephperrott / @atscott can pitch in on that?
I can certainly do a follow-up to move it
Member
There was a problem hiding this comment.
👍 for sure something we can follow-up on (if we even want to do something)
The `@angular/language-service` package was not needed for integration tests or benchmarks. Removing this dependency simplifies the build configuration.
This commit updates the VSCode Angular Language Service extension to use the `@angular/language-service` package built from source within the workspace, rather than a version downloaded from npm. This change simplifies development and testing by ensuring the extension always uses the latest code from the local repository. The Bazel build configuration, VSCode launch settings, and e2e tests have been updated to reflect this change.
This change updates the build configuration to include the @angular/language-server package in the standard framework release output. By integrating it into the release train, we ensure that it is versioned and published consistently with the rest of the Angular framework.
This commit migrates the vscode-ng-language-service to use the in-repo `ts_project` macro, which has strict dependency checking enabled. This improves build-time dependency validation and helps ensure that all dependencies are explicitly declared. As part of this change, redundant `tsconfig.json` files have been removed in favor of a centralized configuration, and `jasmine_test` rules have been updated to the standard macro. A minor code adjustment in `server/src/session.ts` was also made to improve error handling.
744b1a4 to
b99c52e
Compare
atscott
approved these changes
Oct 9, 2025
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 9, 2025
This commit updates the VSCode Angular Language Service extension to use the `@angular/language-service` package built from source within the workspace, rather than a version downloaded from npm. This change simplifies development and testing by ensuring the extension always uses the latest code from the local repository. The Bazel build configuration, VSCode launch settings, and e2e tests have been updated to reflect this change. PR Close #64306
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 9, 2025
This change updates the build configuration to include the @angular/language-server package in the standard framework release output. By integrating it into the release train, we ensure that it is versioned and published consistently with the rest of the Angular framework. PR Close #64306
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 9, 2025
This commit migrates the vscode-ng-language-service to use the in-repo `ts_project` macro, which has strict dependency checking enabled. This improves build-time dependency validation and helps ensure that all dependencies are explicitly declared. As part of this change, redundant `tsconfig.json` files have been removed in favor of a centralized configuration, and `jasmine_test` rules have been updated to the standard macro. A minor code adjustment in `server/src/session.ts` was also made to improve error handling. PR Close #64306
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build: migrate to in-repo ts_project with strict deps
This commit migrates the vscode-ng-language-service to use the in-repo
ts_projectmacro, which has strict dependency checking enabled. This improves build-time dependency validation and helps ensure that all dependencies are explicitly declared.As part of this change, redundant
tsconfig.jsonfiles have been removed in favor of a centralized configuration, andjasmine_testrules have been updated to the standard macro. A minor code adjustment inserver/src/session.tswas also made to improve error handling.build: add @angular/language-server to framework release output
This change updates the build configuration to include the
@angular/language-server package in the standard framework release
output.
By integrating it into the release train, we ensure that it is versioned and published consistently with the rest of the Angular framework.
build: use @angular/language-service from source
This commit updates the VSCode Angular Language Service extension to use the
@angular/language-servicepackage built from source within the workspace, rather than a version downloaded from npm.This change simplifies development and testing by ensuring the extension always uses the latest code from the local repository. The Bazel build configuration, VSCode launch settings, and e2e tests have been updated to reflect this change.
build: remove unneeded language-service dependency
The
@angular/language-servicepackage was not needed for integration tests or benchmarks. Removing this dependency simplifies the build configuration.